makepkg-git-i686: accommodate for gettext v0.23.* #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of v0.23, the `msgfmt.exe` program depends on a newly-introduced library, gettext-libtextstyle. In e70ecb7 (minimal-sdk: accommodate for gettext v0.23.*, 2025-01-07), we included that in minimal SDK's sparse checkout, too. But we forgot to update the `makepkg-git` sparse definition for building the i686 variant of `mingw-w64-git`. This did not cause problems during the v2.48.0-rc phase so far because the `git-artifacts` workflow builds the i686 variant in the i686 Git SDK. However, the Azure Pipeline that builds the snapshots (and which I haven't found time to migrate to GitHub Actions in the past two years) still used the x86_64 Git SDK to build the i686 variant of `mingw-w64-git`, and there things fell apart. So let's fix this. In the long run, we will want to stop building i686 packages in the x86_64 Git SDK altogether. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v0.23, the
msgfmt.exeprogram depends on a newly-introduced library, gettext-libtextstyle. In #90, we included that in minimal SDK's sparse checkout, too.But we forgot to update the
makepkg-gitsparse definition for building the i686 variant ofmingw-w64-git. This did not cause problems during the v2.48.0-rc phase so far because thegit-artifactsworkflow builds the i686 variant in the i686 Git SDK.However, the Azure Pipeline that builds the snapshots (and which I haven't found time to migrate to GitHub Actions in the past two years) still used the x86_64 Git SDK to build the i686 variant of
mingw-w64-git, and there things fell apart.So let's fix this.
In the long run, we will want to stop building i686 packages in the x86_64 Git SDK altogether.