Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create remove-packages.yml #40

Conversation

jeremyd2019
Copy link
Contributor

workflow_dispatch action to remove pacman packages, based on sync.yml action

workflow_dispatch action to remove pacman packages, based on sync.yml action

Signed-off-by: jeremyd2019 <[email protected]>
@dscho
Copy link
Member

dscho commented Feb 17, 2025

workflow_dispatch action to remove pacman packages, based on sync.yml action

The sync workflow uses a PUSH_TOKEN (a Personal Access Token which I'd like to replace, eventually, with an installation access token of the GitForWindowsHelper GitHub App) so that after a push, the GitHub workflows that trigger on push (or pull_request) are run, too.

@jeremyd2019
Copy link
Contributor Author

ok, so check-for-missing-dlls will run, which is probably a good idea after removing stuff 😁

@dscho
Copy link
Member

dscho commented Feb 17, 2025

ok, so check-for-missing-dlls will run, which is probably a good idea after removing stuff 😁

And git-artifacts is another one: After git-for-windows/build-extra#588, this particular workflow will implicitly verify that all the bits and pieces required to build a full Git for Windows version are actually safely committed in the git-sdk-* repository, and do not need to be fetched via pacman -S. This is extremely important to be able to base embargoed versions on the respectively preceding version, to be able to work on a branch that branched off at the exact git-sdk-* commit when that preceding version was integrated.

@dscho
Copy link
Member

dscho commented Feb 17, 2025

A viable alternative would be to move this workflow to git-for-windows-automation, and use actions/create-github-app-token@v1 to obtain the respective installation access token. You may want to adjust the workflow to open a PR instead of pushing to main, then, though ;-)

@jeremyd2019
Copy link
Contributor Author

that would have the added benefit of not needing to copy the workflow to the other 2 sdk repos and subsequently keep them in sync. but I don't even know if a workflow is worth it if a PR is what you want, this is presumably a rare action that could be undertaken manually.

@jeremyd2019 jeremyd2019 deleted the jeremyd2019-remove-packages branch February 18, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants