change ghc-config to use the path ghc instead of TEST_HC #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the hard-coded system $PATH
ghc
to buildghc-config
instead of the make variableTEST_HC
, which brings the make behaviour in line Hadrian. Ideally we would useGHC_STAGE0
fromconfig.mk
, but I have been unable to get that to work via imports. Running the testsuite viamake test
before and after the changes (without a cross-compiler target) results in the same outputs, so it seems like this isn't causing any side-effect changes.Alternately, I also considered matching the locators for other tools located in this same
boilerplate.mk
file, as follows, but this resulted in the same error for whatever reason.And these all result in an error message matching this:
with this excerpt indicating that the variable isn't defined properly
Given that the make builds aren't sticking around for very long, I don't think it's worth it to spend further time debugging when the system ghc bandaid appears to work.