Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-Up Multiscale Branch #9

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

methylDragon
Copy link

@methylDragon methylDragon commented Aug 2, 2019

PR Description

This PR cleans up the multiscale branch and proposes a merge into master, since MGM and MGM multiscale encompass the functionalities covered by the current master HEAD.

Changes Introduced

Cleanup

  • Cleans up the README
  • Cleans up the directories and isolates builds to a build directory
    • With an updated CMakeLists. New calls and compilation instructions are added to the README.

Configuration and Library Packaging

  • Makes MGM an includable library
  • Change the smartparameter preprocessor directive to allow for editing of the set smart parameter value
  • Makes all smart parameter calls refer to the same variable
    • This is so anyone who needs to reconfigure them programmatically can do so
    • This is done by adding a new smartparameter.cc source file and making use of extern

Introduce ROS compatibility

  • Also edits the CMakeLists for conditional ROS compatibility

    * mgm and mgm_multi now access the same code
    * better separation header/code
    * added image shift by fft to generate subpixel displacements
    * changes mgm_costvolume.h to support subpixel costvolumes
    * add minfilter and small region filter
>> DUMP_COSTVOLUME=1 ./mgm_multi -S 0 im{L,R}.png disp.tif

fid = open ('costvolume_right.dat', 'rb');
x = fid.read(4*4) # 4 32bit ints
meta = struct.unpack('iiii', x)
numfloats = meta[0]*meta[1]*meta[2]

x = fid.read(4*numfloats)
data = np.array(struct.unpack('%df'%numfloats, x))
data = data.reshape([meta[1], meta[0], meta[2]])
@methylDragon methylDragon mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants