feat(subscriptions): Add create subscriptions RPC #6499
+1,146
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
shruthilayaj
commented
Nov 8, 2024
Comment on lines
+370
to
+373
| rounded_ts = ( | ||
| int(timestamp.replace(tzinfo=UTC).timestamp() / self.time_window_sec) | ||
| * self.time_window_sec | ||
| ) |
There was a problem hiding this comment.
hack for now, we want to round this to the lowest available granularity (15s) more context here
shruthilayaj
commented
Nov 8, 2024
Comment on lines
+348
to
+353
| if (self.request_name, self.request_version) not in REQUEST_TYPE_ALLOWLIST: | ||
| raise InvalidSubscriptionError( | ||
| f"{self.request_name} {self.request_version} not supported." | ||
| ) | ||
|
|
||
| # TODO: Validate no group by, having, order by etc |
There was a problem hiding this comment.
I'll add more validation in a follow up so it's easier to review
volokluev
reviewed
Nov 8, 2024
@volokluev Creating a subscription requires validation, so I needed to build and run the request before storing it. That introduces the RPCSubscriptionData class. And basically once I introduced it in one place, I kinda had to follow all the typing issues and handle it everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CreateSubscription RPC endpoint. There wasn't a clean way I could split this PR up into smaller chunks so I ended up adding rpc support for the entire the subscriptions pipeline (although a large chunk of it is test coverage).