-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(replay): MaskAll* set to false should unmask all on iOS #4257
Open
krystofwoldrich
wants to merge
2
commits into
main
Choose a base branch
from
kw/fix/replay-mask-all-set-false-ios
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
November 8, 2024 21:45
krystofwoldrich
changed the title
fix(replay): MaskAll* set to false should unmask all
fix(replay): MaskAll* set to false should unmask all on iOS
Nov 8, 2024
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
728164b+dirty | 335.93 ms | 342.94 ms | 7.01 ms |
5571a20+dirty | 359.52 ms | 389.80 ms | 30.28 ms |
76d1baf+dirty | 339.02 ms | 408.65 ms | 69.63 ms |
d197b5c+dirty | 258.75 ms | 313.61 ms | 54.86 ms |
baa882f+dirty | 449.30 ms | 540.40 ms | 91.10 ms |
12427f4+dirty | 379.48 ms | 400.92 ms | 21.44 ms |
5446992+dirty | 371.61 ms | 390.00 ms | 18.39 ms |
ac41368+dirty | 395.91 ms | 451.17 ms | 55.26 ms |
9cd0e9f+dirty | 383.65 ms | 418.65 ms | 35.00 ms |
eb1e19f+dirty | 391.37 ms | 418.27 ms | 26.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
728164b+dirty | 7.15 MiB | 8.12 MiB | 997.71 KiB |
5571a20+dirty | 7.15 MiB | 8.20 MiB | 1.05 MiB |
76d1baf+dirty | 7.15 MiB | 8.09 MiB | 964.41 KiB |
d197b5c+dirty | 7.15 MiB | 8.09 MiB | 962.72 KiB |
baa882f+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
12427f4+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
5446992+dirty | 7.15 MiB | 8.12 MiB | 999.45 KiB |
ac41368+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
9cd0e9f+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
eb1e19f+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 1289.40 ms | 1298.40 ms | 9.00 ms |
5a22220+dirty | 1209.49 ms | 1220.94 ms | 11.45 ms |
c398f67+dirty | 1219.67 ms | 1225.66 ms | 5.99 ms |
27ef4ee+dirty | 1293.52 ms | 1296.08 ms | 2.56 ms |
d8668ce+dirty | 1225.18 ms | 1228.08 ms | 2.90 ms |
e73f4ed+dirty | 1243.27 ms | 1244.52 ms | 1.25 ms |
3853f43+dirty | 1221.82 ms | 1242.64 ms | 20.82 ms |
9c48b2c+dirty | 1246.96 ms | 1255.73 ms | 8.77 ms |
70caa60+dirty | 1218.27 ms | 1230.30 ms | 12.03 ms |
eb1e19f+dirty | 1209.56 ms | 1214.94 ms | 5.38 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 2.36 MiB | 2.83 MiB | 481.15 KiB |
5a22220+dirty | 2.36 MiB | 2.92 MiB | 570.21 KiB |
c398f67+dirty | 2.36 MiB | 3.04 MiB | 696.27 KiB |
27ef4ee+dirty | 2.36 MiB | 2.85 MiB | 500.03 KiB |
d8668ce+dirty | 2.36 MiB | 3.08 MiB | 737.08 KiB |
e73f4ed+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
3853f43+dirty | 2.36 MiB | 2.85 MiB | 499.81 KiB |
9c48b2c+dirty | 2.36 MiB | 2.85 MiB | 495.77 KiB |
70caa60+dirty | 2.36 MiB | 2.83 MiB | 479.27 KiB |
eb1e19f+dirty | 2.36 MiB | 3.08 MiB | 737.21 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 1266.20 ms | 1267.52 ms | 1.32 ms |
5a22220+dirty | 1246.18 ms | 1249.61 ms | 3.43 ms |
c398f67+dirty | 1227.31 ms | 1230.00 ms | 2.69 ms |
27ef4ee+dirty | 1236.41 ms | 1244.90 ms | 8.49 ms |
d8668ce+dirty | 1249.70 ms | 1242.31 ms | -7.39 ms |
e73f4ed+dirty | 1282.90 ms | 1309.30 ms | 26.40 ms |
3853f43+dirty | 1271.74 ms | 1278.04 ms | 6.30 ms |
9c48b2c+dirty | 1253.39 ms | 1256.30 ms | 2.91 ms |
70caa60+dirty | 1279.08 ms | 1281.54 ms | 2.46 ms |
eb1e19f+dirty | 1229.91 ms | 1231.63 ms | 1.71 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 2.92 MiB | 3.40 MiB | 488.08 KiB |
5a22220+dirty | 2.92 MiB | 3.48 MiB | 575.81 KiB |
c398f67+dirty | 2.92 MiB | 3.60 MiB | 701.89 KiB |
27ef4ee+dirty | 2.92 MiB | 3.41 MiB | 503.72 KiB |
d8668ce+dirty | 2.92 MiB | 3.64 MiB | 742.99 KiB |
e73f4ed+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
3853f43+dirty | 2.92 MiB | 3.41 MiB | 503.54 KiB |
9c48b2c+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
70caa60+dirty | 2.92 MiB | 3.39 MiB | 486.04 KiB |
eb1e19f+dirty | 2.92 MiB | 3.64 MiB | 742.82 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR fixes change of names in sentry-cococa from redactAll* to maskAll*.
This PR adds tests to avoid this bug in the future.
💚 How did you test it?
sample app locally, integration tests
📝 Checklist
sendDefaultPII
is enabled