Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bumps sample app to RN 0.76.1 #4207

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

chore(deps): Bumps sample app to RN 0.76.1 #4207

wants to merge 12 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Oct 25, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bumps sample app to RN 0.76.1

⚠️ At the current state the upgrade fixes #4188 but introduces the following iOS error that is still investigated.

(NOBRIDGE) ERROR  ReferenceError: An error was thrown when attempting to render log messages via LogBox.
Property 'setImmediate' doesn't exist

Refs:

💡 Motivation and Context

RN 0.76.0 release

Fix #4188

💚 How did you test it?

Manual Testing, CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.29 ms 1225.88 ms 4.59 ms
Size 2.36 MiB 3.10 MiB 751.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
5a22220+dirty 1209.49 ms 1220.94 ms 11.45 ms
c398f67+dirty 1219.67 ms 1225.66 ms 5.99 ms
27ef4ee+dirty 1293.52 ms 1296.08 ms 2.56 ms
d8668ce+dirty 1225.18 ms 1228.08 ms 2.90 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
eb1e19f+dirty 1209.56 ms 1214.94 ms 5.38 ms

App size

Revision Plain With Sentry Diff
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
5a22220+dirty 2.36 MiB 2.92 MiB 570.21 KiB
c398f67+dirty 2.36 MiB 3.04 MiB 696.27 KiB
27ef4ee+dirty 2.36 MiB 2.85 MiB 500.03 KiB
d8668ce+dirty 2.36 MiB 3.08 MiB 737.08 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
eb1e19f+dirty 2.36 MiB 3.08 MiB 737.21 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
e6a2b88+dirty 1221.27 ms 1222.12 ms 0.86 ms

App size

Revision Plain With Sentry Diff
e6a2b88+dirty 2.36 MiB 3.08 MiB 735.59 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 572.20 ms 617.43 ms 45.22 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2534337+dirty 597.14 ms 665.04 ms 67.90 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
0677344+dirty 288.40 ms 391.44 ms 103.04 ms
d43a46b+dirty 417.65 ms 472.98 ms 55.33 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
9cab16b+dirty 370.82 ms 416.37 ms 45.55 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
c398f67+dirty 315.08 ms 345.60 ms 30.52 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms

App size

Revision Plain With Sentry Diff
2534337+dirty 7.15 MiB 8.11 MiB 988.68 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
0677344+dirty 7.15 MiB 8.07 MiB 949.80 KiB
d43a46b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
9cab16b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
c398f67+dirty 7.15 MiB 8.21 MiB 1.07 MiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
e6a2b88+dirty 402.42 ms 470.18 ms 67.76 ms

App size

Revision Plain With Sentry Diff
e6a2b88+dirty 7.15 MiB 8.35 MiB 1.20 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.45 ms 1239.77 ms 2.32 ms
Size 2.92 MiB 3.66 MiB 755.41 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms
c398f67+dirty 1227.31 ms 1230.00 ms 2.69 ms
27ef4ee+dirty 1236.41 ms 1244.90 ms 8.49 ms
d8668ce+dirty 1249.70 ms 1242.31 ms -7.39 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
eb1e19f+dirty 1229.91 ms 1231.63 ms 1.71 ms

App size

Revision Plain With Sentry Diff
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB
c398f67+dirty 2.92 MiB 3.60 MiB 701.89 KiB
27ef4ee+dirty 2.92 MiB 3.41 MiB 503.72 KiB
d8668ce+dirty 2.92 MiB 3.64 MiB 742.99 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
eb1e19f+dirty 2.92 MiB 3.64 MiB 742.82 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
e6a2b88+dirty 1252.67 ms 1252.24 ms -0.43 ms

App size

Revision Plain With Sentry Diff
e6a2b88+dirty 2.92 MiB 3.64 MiB 741.24 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 487.37 ms 492.11 ms 4.74 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ac41368 451.47 ms 453.67 ms 2.20 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
c2a4e9b 480.42 ms 485.60 ms 5.18 ms
0677344 327.74 ms 337.14 ms 9.40 ms
e540498 436.26 ms 433.00 ms -3.26 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
70e6261 482.65 ms 495.70 ms 13.05 ms

App size

Revision Plain With Sentry Diff
ac41368 17.73 MiB 20.11 MiB 2.38 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
c2a4e9b 17.73 MiB 20.06 MiB 2.33 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
e540498 17.73 MiB 20.11 MiB 2.37 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
e6a2b88 648.02 ms 633.98 ms -14.04 ms

App size

Revision Plain With Sentry Diff
e6a2b88 17.74 MiB 20.08 MiB 2.34 MiB

@antonis antonis changed the title chore(deps): Bumps sample app to RN 0.76.0 chore(deps): Bumps sample app to RN 0.76.1 Oct 30, 2024
@krystofwoldrich
Copy link
Member

(NOBRIDGE) ERROR ReferenceError: An error was thrown when attempting to render log messages via LogBox.
Property 'setImmediate' doesn't exist

It this still an issue?

@antonis
Copy link
Collaborator Author

antonis commented Nov 7, 2024

(NOBRIDGE) ERROR ReferenceError: An error was thrown when attempting to render log messages via LogBox.
Property 'setImmediate' doesn't exist
It this still an issue?

@krystofwoldrich yes. The iOS sample compiles successfully and the error occurs on load preventing the app from loading. I guess this is some dependency issue but I haven't figured out a solution yet. Any suggestions are welcome 🙇

@antonis
Merge branch 'main' into antonis/chore-samples-rn0.76.0
a731fa4 
# Conflicts:
#	samples/react-native/android/app/src/main/jni/OnLoad.cpp
#	samples/react-native/ios/sentryreactnativesample/AppDelegate.mm
#	samples/react-native/package.json
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich left review comments

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android Sample Application New Architecture Crash with RN 0.75 when profiling is enabled
2 participants
@antonis @krystofwoldrich