Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: task profiling #3396

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

WIP: task profiling #3396

wants to merge 7 commits into from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 28, 2024

This changes the profiler to track tasks across threadpools. It makes use of ActivityComputer, which is currently only patched in our fork and not upstream.

Also, there's currently a blocking issue because with a recent change in TraceLog to clean data structures after a sample is processed (see #3375 (comment)). The problem is that the ActivityComputer relies on reading older stacks when figuring out creator stacktraces (AFAICT). We'd need to find solution for that to make the ActivityComputer work with realtime sessions, while not reverting the indefinitely growing data structures.
Maybe, we could make ActivityComputer process and keep the needed stack trace information at the time that sample occurs, if that is possible?
In any case, I'd wait until the perfview PR with the main changes we need is merged, before opening another set of changes.

@vaind vaind changed the title WIP (blocked): task profiling WIP: task profiling May 28, 2024
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- task profiling ([#3396](https://github.com/getsentry/sentry-dotnet/pull/3396))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 922aac0

@vaind vaind marked this pull request as draft May 28, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant