-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined Dynamic Sampling #111
base: main
Are you sure you want to change the base?
Conversation
it looks good, but what i miss from RFCs often is some kind of diagram to help visualize what we are talking about. then something more like a use case that is a concrete user example: sub trace for example I don't really understand what this means. Sampling on the individual events? There is no trace? |
@JoshFerge This RFC is not yet ready for review, it's still in draft state. |
the sample rates permit, and dynamic sampling will prefer to store traces with | ||
all data available. | ||
|
||
## Sub-Trace Sampling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section will be revisited. Following a conversation with @mydea, we will keep the replay sample rate completely independent of trace sampling (however subject to RFC 109). I'll write up a revision of this section that takes necessary changes into account.
got it. sorry about that. it's an exciting one :D |
Reduce the number of profiles and replays dropped through dynamic sampling by
changing how trace sampling decisions are computed.
Rendered RFC