Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GoCD Slack feed handler to handle failures gracefully #776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IanWoodard
Copy link
Member

This aims to better handle potential failures, especially now that we have quite a few deploy feeds.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.25%. Comparing base (c89c067) to head (d003021).

Files Patch % Lines
src/brain/gocdSlackFeeds/index.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   86.26%   86.25%   -0.02%     
==========================================
  Files         116      116              
  Lines        3306     3310       +4     
  Branches      664      665       +1     
==========================================
+ Hits         2852     2855       +3     
- Misses        440      441       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants