Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Redundant log entries are removed. All information (in-memory result size, query runtime, etc.) is consolidated under the
_log_progress()
method.Another benefit of consolidated log entries is that when using tools such as DataDog, custom metrics can be easily generated from parsed logs:
Because
username
andquery_id
are now tied withdata_length
andrun_time
by putting them in the same log entry.Much easier to track rogue users who like to do
SELECT * FROM big_table
or any other inefficient queries.How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)