Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit autoupdate #3421

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

boxydog
Copy link
Contributor

@boxydog boxydog commented Nov 3, 2024

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools

@boxydog
Copy link
Contributor Author

boxydog commented Nov 3, 2024

FYI ruff complaints before fixes:

pelican/tools/pelican_quickstart.py:90:8: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
   |
89 | def ask(question, answer=str, default=None, length=None):
90 |     if answer == str:
   |        ^^^^^^^^^^^^^ E721
91 |         r = ""
92 |         while True:
   |

pelican/tools/pelican_quickstart.py:113:10: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
111 |         return r
112 | 
113 |     elif answer == bool:
    |          ^^^^^^^^^^^^^^ E721
114 |         r = None
115 |         while True:
    |

pelican/tools/pelican_quickstart.py:137:10: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
135 |                 print("You must answer 'yes' or 'no'")
136 |         return r
137 |     elif answer == int:
    |          ^^^^^^^^^^^^^ E721
138 |         r = None
139 |         while True:
    |

pelican/tools/pelican_themes.py:26:1: PLW0604 `global` at module level is redundant
   |
26 | global _THEMES_PATH
   | ^^^^^^^^^^^^^^^^^^^ PLW0604
27 | _THEMES_PATH = os.path.join(
28 |     os.path.dirname(os.path.abspath(pelican.__file__)), "themes"
   |

Found 4 errors.

Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates, @boxydog 👍

@justinmayer justinmayer merged commit 4ca1454 into getpelican:main Nov 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants