VPCEndpoint: add security group modification #7515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoenkeD
force-pushed
the
feature/VPCEndpoint_security_groups
branch
2 times, most recently
from
3733040
to
4854902
Compare
fix linting fix none list issue
SoenkeD
force-pushed
the
feature/VPCEndpoint_security_groups
branch
from
4854902
to
c39e738
Compare
|
Hi @bblommers , |
bblommers
reviewed
May 6, 2024
|
|
||
| security_group_ids = [] | ||
| for service in vpc_end_points: | ||
| security_group_ids.extend(service.security_group_ids) |
There was a problem hiding this comment.
The failing error is because service.security_group_ids can be None - so you're effectively running security_group_ids.extend(None), which throws the TypeError: 'NoneType' object is not iterable that you can see in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to add / remove security groups for VPCEndpoints (with ModifyVpcEndpoint() ). The changes of this PR allow this and also load the SecurityGroup names when DescribeVpcEndpoint().