Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapml 3933 usetiles usefeatures multi #376

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

turingtestfail
Copy link

@turingtestfail turingtestfail commented Jan 30, 2025

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

Copy link
Collaborator

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! See comments. Thanks!

Copy link
Collaborator

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I have the milestone set up in our community geoserver fork, possibly useful for you.

I think we're working on # 73 here, correct?

@turingtestfail
Copy link
Author

BTW I have the milestone set up in our community geoserver fork, possibly useful for you.

I think we're working on # 73 here, correct?

Yes, that is my understanding

@prushforth
Copy link
Collaborator

BTW I have the milestone set up in our community geoserver fork, possibly useful for you.
I think we're working on # 73 here, correct?

Yes, that is my understanding

You are probably aware then that the UI for usemultiextents must be re-located into the layergroup MapML settings panel. Cheers

@turingtestfail turingtestfail force-pushed the mapml-3933-usetiles-usefeatures-multi branch from 87c3076 to b835f28 Compare February 11, 2025 19:28
@turingtestfail
Copy link
Author

BTW I have the milestone set up in our community geoserver fork, possibly useful for you.
I think we're working on # 73 here, correct?

Yes, that is my understanding

You are probably aware then that the UI for usemultiextents must be re-located into the layergroup MapML settings panel. Cheers

Latest push includes the UI move of usemultiextents

@prushforth
Copy link
Collaborator

Looks good to me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants