Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Take nth bytes' operation #1915

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Add 'Take nth bytes' operation #1915

merged 8 commits into from
Feb 14, 2025

Conversation

Oshawk
Copy link
Contributor

@Oshawk Oshawk commented Sep 25, 2024

Can't re-open #695 so am creating a new PR. Finally got around to updating the branch.

Added an operation to take every 2nd, 3rd etc. byte starting at a given byte. Can be applied to each line. Tests included.

Oshawk and others added 8 commits October 21, 2019 19:39
Added 'Take nth bytes' operation.
Fixed issue where new lines were truncated.
Fixed linting.
Added tests for the 'Take nth byte' operation.
Added tests to index.
@a3957273
Copy link
Member

Thanks for coming back after we left your old PR open for so long. Similar to the 'Remove' PR I've also just merged in, this is also useful for automation. In the future, with these PRs being so linked and relatively low in code, feel free to send in just one PR.

@a3957273 a3957273 merged commit fed10f3 into gchq:master Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants