Implement resolveIdentifier on readonly trees
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airhorns
changed the title
resolveIdentifier on readonly trees
thegedge
approved these changes
Jan 22, 2024
src/api.ts
Outdated
| @@ -150,23 +151,32 @@ export function getType(value: IAnyStateTreeNode): MSTAnyComplexType | IAnyCompl | |||
| return value[$type]; | |||
| } | |||
|
|
|||
| export function getEnv<Env = any>(value: IAnyStateTreeNode): Env { | |||
| /** @hidden */ | |||
| export function getContext(value: IAnyStateTreeNode): InstantiateContext | null { | |||
There was a problem hiding this comment.
nit: since it's used beyond instantiation now, I'd be down for giving InstantiateContext a more generic name.
spec/api.spec.ts
Outdated
| expect(resolveIdentifier(NamedThingClass, instance.map.get("test_key")!, "test_key")?.key).toEqual("test_key"); | ||
| }); | ||
|
|
||
| test("returns null when the identifier doesn't resolve", () => { |
There was a problem hiding this comment.
super nit: returns undefined (which is good too, because that's what MST does!)
airhorns
force-pushed
the
reference-support
branch
2 times, most recently
from
e5569e7 to
ea7d0e1
Compare
airhorns
force-pushed
the
reference-support
branch
from
ea7d0e1 to
e82181a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a
not yet implementedgadget side when going to use this API, figured it wasn't too hard! We implement by keeping the identifier cache around beyond just after we instantiate, instead of only capturing a reference to the env from that context.