Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shouldTrackChanges option to @snapshottedView #107

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

scott-rc
Copy link
Contributor

@scott-rc scott-rc commented Jul 9, 2024

This adds shouldEmitPatchOnChange to @snapshottedView's options so users can opt of emitting patches when snapshotted views for changes.

Tracking snapshotted views causes them to be immediately computed which isn't ideal if you don't need to track their changes.

@scott-rc scott-rc force-pushed the sc/should-track-changes branch 2 times, most recently from 33dc4d9 to c235aad Compare July 10, 2024 17:02
@scott-rc scott-rc marked this pull request as ready for review July 10, 2024 17:06
@scott-rc scott-rc requested review from airhorns and thegedge July 10, 2024 17:06
src/class-model.ts Outdated Show resolved Hide resolved
src/class-model.ts Outdated Show resolved Hide resolved
src/class-model.ts Outdated Show resolved Hide resolved
@scott-rc scott-rc force-pushed the sc/should-track-changes branch from c235aad to e96e7a5 Compare July 10, 2024 18:28
@scott-rc scott-rc requested a review from thegedge July 10, 2024 18:29
Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #107 will not alter performance

Comparing sc/should-track-changes (e96e7a5) with main (3dea56c)

Summary

✅ 11 untouched benchmarks

@scott-rc scott-rc merged commit 688ba37 into main Jul 10, 2024
6 checks passed
@scott-rc scott-rc deleted the sc/should-track-changes branch July 10, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants