Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace event-emitter package with NodeJS builtin events #1399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wommy
Copy link

@wommy wommy commented Sep 24, 2024

event-emitter breaks webpack4 builds with its es5-ext dependency
so i replaced it with node's built in
this is holding back AudioBookShelf's upgrade from nuxt2

pull it, test it out, lmk if you encounter any bugs

es5-ext also occasionally false flags as CVE because of a post install script

@wommy
Copy link
Author

wommy commented Oct 3, 2024

@fchasen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant