Add second onion name for abc.au #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate changing the short onion name for abc.au to no longer use a subdomain (as requested by Tor in #219), we're setting up a second name for them, and once they've migrated over, will remove the original one. A hack is added to the generation script to save the old domain under "abc-legacy" and keep the new domain as just "abc". Refs #222.
nathandyer
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
LGTM, thanks Kunal!
Just noting that I tested both abcau.securedrop.tor.onion as well as abc.au.securedrop.tor.onion, and both loaded the correct SI as expected.
No need to update anything in the directory, but once this is live I'll reach out and coordinate the necessary changes on their landing page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
To facilitate changing the short onion name for abc.au to no longer use a subdomain (as requested by Tor in #219), we're setting up a second name for them, and once they've migrated over, will remove the original one.
A hack is added to the generation script to save the old domain under "abc-legacy" and keep the new domain as just "abc".
Refs #222.
Review Checklist
onboarded.txtare accuratedefault.rulesets.TIMESTAMP.gzhas been updated, extracting that file and inspecting the contents of the JSON file produces the expected rulesPath Prefix:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAMEindex.htmlhas been updated using./update_index.shPost-Deployment Checklist