Disallow new onion names with subdomains; remove tv2.dk and iqss.harvard #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an extra subdomain causes issues in Tor Browser, because the first-party domain is incorrectly determined. Tor has asked us (in #219) to stop adding new domains, which is simple enough. A new check verifies there's no period in the part before ".securedrop.tor.onion". If there is and it's not in the exemption list, error out. Refs #219.
Not currently listed in our directory. Fixes #220.
nathandyer
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
LGTM; left one comment about a nit, which may be intentional.
Approving but waiting to merge until I confirm with @legoktm
| "webapps.aljazeera.net", | ||
| "www.apache.be", |
There was a problem hiding this comment.
These two new exceptions are the only ones prefixed with www - is that intentional?
There was a problem hiding this comment.
Just a coincidence, these entries have to match how they're listed in onboarded.txt: https://github.com/freedomofpress/securedrop-https-everywhere-ruleset/blob/470ac857ae1c320794f46e3be0bede206e92e10e/onboarded.txt
There was a problem hiding this comment.
Ah, makes sense - thanks for confirming!
|
No changes necessary in SD directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Review Checklist
onboarded.txtare accuratedefault.rulesets.TIMESTAMP.gzhas been updated, extracting that file and inspecting the contents of the JSON file produces the expected rulesPath Prefix:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAMEindex.htmlhas been updated using./update_index.shPost-Deployment Checklist