Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): do not report empty constructors, enable reports for receive #9288

Merged
merged 1 commit into from
Nov 9, 2024
Merged

fix(coverage): do not report empty constructors, enable reports for receive #9288

merged 1 commit into from
Nov 9, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 8, 2024 •
edited
Loading

Motivation

Closes #9270

Solution

  • do not count empty constructor as coverage function
  • receive anchor can now properly found, enable coverage report for
  • tests

@grandizzy grandizzy marked this pull request as ready for review November 8, 2024 16:23
@grandizzy grandizzy merged commit 91d3349 into foundry-rs:master Nov 9, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-9270 branch November 9, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: constructor() payable {} does not work correctly with code coverage
2 participants
@grandizzy @klkvr