Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article versioning, extended units and alternative article sharing (#1058) #1073

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lentschi
Copy link
Contributor

@lentschi lentschi commented Oct 11, 2024

In this PR (addressing #1058) we originally wanted to extend article units only, however during development it became clear, that other parts had to be refactored/rewritten too - so it now encompasses these three major changes:

  1. Article versioning
  2. Article list synchronization
  3. Article unit system

For details see the architecture notes describing the changes.

@lentschi lentschi force-pushed the feature/1058-extended-article-units branch from cb74897 to 2fa467d Compare November 3, 2024 10:03
@lentschi lentschi changed the title Started with #1058 First implementation of #1058 Nov 3, 2024
@lentschi lentschi marked this pull request as ready for review November 3, 2024 10:04
@lentschi lentschi force-pushed the feature/1058-extended-article-units branch from 2fa467d to 7ac72f4 Compare November 3, 2024 11:05
@lentschi lentschi changed the title First implementation of #1058 Article versioning, extended units and alternative article sharing (#1058) Nov 8, 2024
@twothreenine
Copy link
Contributor

Solves #422 Improve unit handling
Solves #474 by allowing price input per price unit (I think the rounding discrepancy should be in a tolerable range now)
Solves #827 Minimum order quantity for certain articles
Solves #843 Allow to insert an integer / number in orders to set amount of a certain product
Solves #850: Full article versioning (still to implement: apply new version specifically to future/current/closed/settled orders, and/or specific order)
Fixes #1056 Critical bug: Article price changes when closing order
Makes #710 obsolete (unit_quantity == 0 causes 500 when viewing group_order)

We've decided against supporting ordering partial cases, so #645 won't be solved, however if you choose a scalar unit, you can order loose quantities like 2.5 kg.

Sharedlist issues which will probably be affected:
#675 feature: (Un)check articles for article sync
#1030 Synchronize from external database fails with "out of range" error
#1033 Access control for shared suppliers

Note: Implementation of #569 (Work with datafoodconsortium) could be done based on this PR.

to-do: Check issue numbers below 400

@lentschi lentschi force-pushed the feature/1058-extended-article-units branch 3 times, most recently from 11aedea to 7474d83 Compare November 10, 2024 09:39
@lentschi lentschi force-pushed the feature/1058-extended-article-units branch from 7474d83 to 1e74ab9 Compare November 10, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants