out_kafka: emit a metric when librdkafka signals an error #9588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveas
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
Curl output showing the metric using a config that's intentionally broken (bad auth). As you can see no dropped records according to existing metrics, but the new metric shows the errors. |
seveas
force-pushed
the
kafka-errors-metric
branch
from
23e27ab
to
2fa911a
Compare
seveas
force-pushed
the
kafka-errors-metric
branch
from
2fa911a
to
c17abe2
Compare
seveas
changed the title
seveas
force-pushed
the
kafka-errors-metric
branch
from
c17abe2
to
775f132
Compare
seveas
force-pushed
the
kafka-errors-metric
branch
from
775f132
to
2ef65d1
Compare
The async nature of the kafka output makes the fluentbit_output_dropped_records_total insufficient to determine whether there are problems sending messages to kafka. fluent-bit considers a message delivered when it has been added to the librdkafka buffers. If librdkafka subsequently fails to deliver the message, the only feedback is a log message such as: ``` [2024/11/12 07:56:45] [ warn] [output:kafka:azure] message delivery failed: Local: Message timed out ``` So let's add a metric that exposes how often librdkafka signals that it has problems talking to kafka. Signed-off-by: Dennis Kaarsemaker <[email protected]>
seveas
force-pushed
the
kafka-errors-metric
branch
from
2ef65d1
to
79bae5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.