config_format: windows: Handle static config on windows correctly #9582
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current master on Fluent Bit, we didn't follow the changes of enabling FLB_STATIC_CONF case.
With tons of changes after we introduced that option on cmake, this option does not work for using enabling with
-DFLB_STATIC_CONF=/path/to/confdir
.I followed the subsequent changes since that feature was introduced and plug a NULL pointer exception for
feof(3)
.This is because this is always needed for reading from the actual configuration files. However, reading from buffer on memory is not needed to check the end of the contents for Fluent Bit configuration.
I supposed that we can omit that checker when enabling static config.
Closes #9556.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.