-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOME/IP input plugin #9570
base: master
Are you sure you want to change the base?
SOME/IP input plugin #9570
Conversation
The SOME/IP C library is a wrapper around vsomeip. Signed-off-by: Anthony Payne <[email protected]>
Signed-off-by: Anthony Payne <[email protected]>
All tests pass and valgrind does not show any memory errors. Signed-off-by: Anthony Payne <[email protected]>
Signed-off-by: Anthony Payne <[email protected]>
Signed-off-by: Anthony Payne <[email protected]>
Signed-off-by: Anthony Payne <[email protected]>
Added code in error legs to free decode buffer. Signed-off-by: Anthony Payne <[email protected]>
Someip input plugin
Example config file is included in the PR,
|
Debug log from runtime tests is attached. |
Output from valgrind:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, I think we need to look at those runtime dependencies though at the very least - also do we need to include them in the target builds as well under ./packaging/distros
?
I don't think we can realistically globally enable this for every supported target. It also seems to use C++ compilation and dependencies.
libboost-system-dev \ | ||
libboost-thread-dev \ | ||
libboost-filesystem-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is including the dev libraries in the runtime image - we should just have the minimal set of libraries needed for running fluent bit, not those for building it.
@@ -221,6 +227,9 @@ RUN echo "deb http://deb.debian.org/debian bookworm-backports main" >> /etc/apt/ | |||
libatomic1 \ | |||
libgcrypt20 \ | |||
libyaml-0-2 \ | |||
libboost-system-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, do we really need the development libraries here or can we just use the runtime ones?
libboost-system-dev \ | ||
libboost-thread-dev \ | ||
libboost-filesystem-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're including these development libraries but not actually enabling the plugin itself - is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we globally enabled it which may be an entirely separate issue.
FetchContent_Declare( | ||
vsomeip3 | ||
GIT_REPOSITORY https://github.com/COVESA/vsomeip | ||
GIT_TAG 0b83e24d16e1611958194e9b727136522f46556b # 3.5.1 | ||
) | ||
FetchContent_MakeAvailable(vsomeip3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies are generally vendored into the /lib
directory and not fetched remotely.
@@ -227,6 +227,7 @@ if(FLB_ALL) | |||
set(FLB_IN_NGINX_STATUS 1) | |||
set(FLB_IN_EXEC 1) | |||
set(FLB_IN_UNIX_SOCKET 1) | |||
set(FLB_IN_SOMEIP 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can enable this globally without considering all platforms that are supported including Windows and macOS configuration.
@@ -0,0 +1,138 @@ | |||
/* Fluent Bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a C++ file, is that just a standard example and/or can it be C only? It seems to require a C++ compiler by looking at the example cmake linkage.
For new plugins we must ensure it builds for all targets and CI so I've triggered that. It looks like we have a lot of failures around missing dependencies and the like in various places/platforms. |
This change introduces a new input plugin, in_someip. This plugin is used to subscribe to events and capture notifications from a SOME/IP network. It also can be used in inject SOME/IP requests and capture the response to the data pipeline.
The input plugin uses an open source implementation of the SOME/IP stack, vsomeip. This library is used unchanged, but a wrapper library, libsomeip-c, exposing C-language APIs is part of the PR.
For reference to SOME/IP: protocol specification.
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.