Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: linux: Compile and execute internal test on non-amd64 platforms Linux #9313

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Aug 30, 2024

This workflow could be used for aarch64 Linux testing purpose such as #8851.

Also, uraimo/run-on-arch-action@v2 workflow component can handle s390x and ppc64le architectures by QEMU emulations.
So, we can add these targets in the future.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-qemu-aarch64-linux-workflow branch from 8de1c16 to 6d7ae8f Compare September 2, 2024 03:16
@cosmo0920 cosmo0920 marked this pull request as ready for review September 3, 2024 02:12
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-qemu-aarch64-linux-workflow branch from 7d9ca2b to 08ed056 Compare September 3, 2024 05:32
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-qemu-aarch64-linux-workflow branch 4 times, most recently from 17a7e1b to ca2a696 Compare September 4, 2024 06:14
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-qemu-aarch64-linux-workflow branch 5 times, most recently from 6fdd929 to acf4e35 Compare September 4, 2024 10:06
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-qemu-aarch64-linux-workflow branch 2 times, most recently from 6663f13 to 0e155c6 Compare September 4, 2024 12:06
@cosmo0920
Copy link
Contributor Author

The aarch64 unit testing on actuated test runner got green: https://github.com/fluent/fluent-bit/actions/runs/10700447782

@cosmo0920 cosmo0920 changed the title workflows: aarch64: linux: Compile and execute internal test on QEMU aarch64 Linux workflows: linux: Compile and execute internal test on non-amd64 platforms Linux Sep 4, 2024
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a CI perspective.

.github/workflows/unit-tests.yaml Outdated Show resolved Hide resolved
# We chain this after Linux one as there are CPU time costs for QEMU emulation
needs:
- run-ubuntu-unit-tests
runs-on: ubuntu-20.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to look at stepping this up as well soon, 22 is the default and 24 is coming. Not a blocker now though.

@patrick-stephens patrick-stephens merged commit 2ff5372 into master Sep 5, 2024
12 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-add-qemu-aarch64-linux-workflow branch September 5, 2024 11:23
legendary-acp pushed a commit to ctrlb-hq/ctrlb-fluent-bit that referenced this pull request Oct 1, 2024
…forms Linux (fluent#9313)

* workflows: aarch64: linux: Compile and execute internal test on QEMU aarch64 Linux

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: aarch64: Omit to execute flb-it-utils and flb-it-pack tests

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: aarch64: Tweak for easily to extend for other non-amd64 platforms

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: aarch64: Add actuated runner settings for aarch64

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: Reuse qemu settings for s390x CI task

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: s390x: Remove omit option to execute pack and utils internal tests

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: Remove needless conditions

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: aarch64: Shorten the timeout from 60mins. to 10mins.

Signed-off-by: Hiroshi Hatake <[email protected]>

---------

Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants