out_influxdb: Handle signed/unsigned integer as influx's integer of that representation #9301
+532
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
changed the title
…hat representation This is because in their line protocol, it needs to add "i" suffix for handling a value as an integer: | Datatype | Element(s) | Description | |:--------:|:------------:|:------------| | Integer | Field values | Signed 64-bit integers (-9223372036854775808 to 9223372036854775807). Specify an integer with a trailing i on the number. Example: 1i | So, we need to add "i" suffix for signed/unsigned integer values. ref: https://docs.influxdata.com/influxdb/v1/write_protocols/line_protocol_reference/ Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-handle-integer-values-as-integer-representation-on-influxdb-line-protocol
branch
from
bfce9a7
to
3c40043
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
…b's line protocol Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
edsiper
reviewed
Sep 4, 2024
…n the line protocol Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
edsiper
deleted the
cosmo0920-handle-integer-values-as-integer-representation-on-influxdb-line-protocol
branch
|
@cosmo0920 would you please submit a backport for 3.1 ? |
|
Sure, I will do. |
7 tasks
|
Thanks @cosmo0920 it is nicely done without breaking change by default ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because in their line protocol, it needs to add "i" suffix for handling a value as an integer:
So, we need to add "i" suffix for signed/unsigned integer values if needed.
ref: https://docs.influxdata.com/influxdb/v1/write_protocols/line_protocol_reference/
Closes #9120.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
To ingest already mapped as float field(s) with integer type, then got:
This is expected behavior because this indicates that the integer type of influxdb line protocol was used correctly.
Without
use_integer: Off(default value):With
use_integer: On:If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1451
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.