macos: core: macOS coroutine unstability fixes #7820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In macOS, the size of pthread stack min of Intel Mac (x64) and Apple Silicon (M1/M2) is smaller than the Linux one.
This means that the concrete values are:
Intel Mac
PTHREAD_STACK_MIN = 8192
(3 * PTHREAD_STACK_MIN) / 2 = 12288 which means fluent-bit's minimum stack size
Apple Silicon
PTHREAD_STACK_MIN = 16384
(3 * PTHREAD_STACK_MIN) / 2 = 24576 which means fluent-bit's minimum stack size
They shouldn't be enough for libresolv API which needs to use heap memories:
res_ninit(statep)
.When increasing the coroutine size to:
24576 bytes (24KiB) on Intel Mac and 36864 bytes (36KiB) on Apple Silicon respectively, the heap memory corruptions are not occurred.
Related to #7670.
additional contexts
I tested for the minimum code:
The canary CI results are:
https://github.com/fluent/fluent-bit/actions/runs/5832454631
https://github.com/fluent/fluent-bit/actions/runs/5832456028
https://github.com/fluent/fluent-bit/actions/runs/5832457491
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.