Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: windows: Make more rigid handling for caches #7780

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

cosmo0920
Copy link
Contributor

The previous PR #7773 might not handle restoring caches for vcpkgs correctly.
Adding restore-keys should handle to restore the caches of vcpkg.
It behaves for the searching prefix for specifying which is the most appropriate cache.

CI result is here:


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Thie is because it has been already used Windows-$arch-vcpkg-%Y%m%d style.
No needed to append additional %Y%m%d suffix.

Signed-off-by: Hiroshi Hatake <[email protected]>
@cosmo0920 cosmo0920 marked this pull request as ready for review August 2, 2023 03:49
@cosmo0920 cosmo0920 added ok-package-test Run PR packaging tests ok-to-test labels Aug 2, 2023
@cosmo0920 cosmo0920 temporarily deployed to integration August 2, 2023 03:50 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to integration August 2, 2023 03:57 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr August 2, 2023 04:04 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens merged commit 176982b into master Aug 2, 2023
84 of 118 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-more-rigid-handling-for-caches branch August 2, 2023 09:23
Wiston999 pushed a commit to Wiston999/fluent-bit that referenced this pull request Aug 7, 2023
* workflows: windows: Use restore-keys element for surely restoring

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: windows: Use the cache primary key as-is

Thie is because it has been already used Windows-$arch-vcpkg-%Y%m%d style.
No needed to append additional %Y%m%d suffix.

Signed-off-by: Hiroshi Hatake <[email protected]>

---------

Signed-off-by: Hiroshi Hatake <[email protected]>
leonardo-albertovich pushed a commit that referenced this pull request Oct 5, 2023
* workflows: windows: Use restore-keys element for surely restoring

Signed-off-by: Hiroshi Hatake <[email protected]>

* workflows: windows: Use the cache primary key as-is

Thie is because it has been already used Windows-$arch-vcpkg-%Y%m%d style.
No needed to append additional %Y%m%d suffix.

Signed-off-by: Hiroshi Hatake <[email protected]>

---------

Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants