in_podman_metrics: Added remove_stale_counters opt #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloxxl
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
pabloxxl
force-pushed
the
remove_stale_counters
branch
from
d485461
to
59d882d
Compare
pabloxxl
force-pushed
the
remove_stale_counters
branch
from
59d882d
to
f6fa719
Compare
|
None of failed unit tests seem to be connected with in_podman plugin - should I work on reruning them anyway? |
pabloxxl
force-pushed
the
remove_stale_counters
branch
from
f6fa719
to
4f58516
Compare
pabloxxl
force-pushed
the
remove_stale_counters
branch
from
4f58516
to
25851dd
Compare
|
I've rebased my branch and all checks are now passing |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
pabloxxl
force-pushed
the
remove_stale_counters
branch
from
25851dd
to
5142d63
Compare
For environments with containers being created and removed often, it might be good to specify an option to remove counters for removed containers. This option is default to false, since it increases resource consumption of plugin Signed-off-by: Paweł Cendrzak <[email protected]>
pabloxxl
force-pushed
the
remove_stale_counters
branch
from
5142d63
to
3cdbe9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For environments with containers being created and removed often, it might be good to specify an option to remove counters for removed containers. This option is default to false, since it increases resource consumption of plugin
For systems where containers are removed (or recreated with different id), someone might want to not to reflect those containers in metrics anymore - I've added an option, remove_stale_counters (default to false). With this option, if container id is no longer visible in containers.json, will be removed.
Since there is no possibility to remove counter just for one container instance, if such situation is detected, all counters are "recreated" - removed and created again.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Example configuration file for the change
stale.conf.txt
Debug log output from testing the change
valgrind_real_stale.txt
valgrind_stale.txt
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
documentation pr
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.