Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_kubernetes: add improved error message for meta tag parsing. #6746

Closed
wants to merge 1 commit into from

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Jan 27, 2023

Improve the somewhat obscure warning message that is thrown when parsing the tag in the kubernetes filter fails. Also promote it to an error message.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan self-assigned this Jan 27, 2023
@pwhelan pwhelan temporarily deployed to pr January 27, 2023 12:47 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr January 27, 2023 12:47 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr January 27, 2023 13:03 — with GitHub Actions Inactive
@pwhelan
Copy link
Contributor Author

pwhelan commented Aug 31, 2023

closing for now.

@pwhelan pwhelan closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant