Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
network: ARES_OPT_TRIES must be set to update opt.tries (#8587)
* fix: ARES_OPT_TRIES must be set to update opt.tries This is a typo I spotted in reviewing #5613 - the current code appears to set opt.tries to 2 (from the default 3) but because the corresponding optflag is not set it will be ignored. See the c-ares code that is being called: https://github.com/c-ares/c-ares/blob/e4a4346596c62621704371270220b567b0ddd83d/src/lib/ares_options.c#L310-L316 Signed-off-by: bazzargh <[email protected]> * fix: remove retries following comments in the PR, the preferred option is to remove the ineffective retries option and the mask that would have caused it to have any effect. The resulting code should behave exactly as before, since the mask was required for the original retries option to work, and it has never been set; so no additonal tests are supplied. Signed-off-by: bazzargh <[email protected]> --------- Signed-off-by: bazzargh <[email protected]>
- Loading branch information