fix: Catch all sdk errors #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
floydspace
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Hey @godu
I fixed a little bit:
- the ServiceError should not be returned in the methods, it will never be catched by
catchTagbecause it does not have thename(mapped to_tag), it is defined on the final concrete errors only. - plus fixed possible bug if aws error name is the same like the error exported by us, for example
InternalServerErrorin dynamodb client, it will be imported from aws and exported with the same name.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got it :)
Some errors don't end by "Exception", but inherit the
ServiceError.