Make XdpAppInfo more testable #1627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purely cosmetics.
They're not public.
* Add space before '('
* gchar → char
* Remove stray newline
It's unused.
Makes it slightly easier to read.
It takes care of figuring out which app info kind must be created.
This more robust than trying to keep track of all the things that are not host and as a bonus also removes a bunch of code.
This makes it easier to see what's actually going on and we don't have to keep track of so many arguments with "do not set" values.
This just creates a bit more order.
swick
force-pushed
the
wip/app-info-refactor
branch
from
8a662e1 to
3c2fdf6
Compare
The xdp_app_info_*_new functions take care of figuring out if the testing harness is trying to create this XdpAppInfo type, and then creates an instance, based on a bunch of subtype specific environment variables. The next commit will start making use of it.
Now that the subclasses handle testing requirements themselves, the generic XdpAppInfo code can stop caring about it, and the XdpAppInfoTest class can be dropped. The testing harness is also adjusted to take advantage of this new feature. In particular, for USB query support the flatpak kind needs to be used. This makes it possible to run test with specific or all XdpAppInfo types that we have.
swick
force-pushed
the
wip/app-info-refactor
branch
from
7694452 to
cc1cfa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits