Try harder to find the host path for the documents #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grulja
reviewed
Jan 15, 2025
xhorak
force-pushed
the
openuri-tryharder
branch
from
f2371db to
fd24f44
Compare
grulja
reviewed
Jan 20, 2025
When the access to the directory is provided by the portal (like browser download directory) the stored files in the directory are not found by xdp_get_real_path_for_doc_path and /run/user/... path is opened instead of host path by the OpenFile or OpenDirectory portal. This fix tries to recreate host path from the document id and rest of the given path.
xhorak
force-pushed
the
openuri-tryharder
branch
from
fd24f44 to
27194b7
Compare
|
Not a full review but changes like this really need tests. |
|
There are now python based tests for the document portal (#1594). Would be great if a test for the case which this PR is trying to fix was added. |
swick
reviewed
Jan 22, 2025
| { | ||
| gchar *result; | ||
| g_autofree char *host_path = xdp_get_real_path_for_doc_id (doc_id); | ||
| g_autofree char *doc_path_regex = g_strconcat("/run/user/[0-9]+/doc/", doc_id, "/[^/]+(.*)", NULL); |
There was a problem hiding this comment.
I think this could be avoided if xdp_looks_like_document_portal_path would add another out param which returns the path relative to the document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the access to the directory is provided by the portal (like browser download directory) the stored files in the directory are not found by xdp_get_real_path_for_doc_path and /run/user/... path is opened instead of host path by the OpenFile or OpenDirectory portal.