Merge pull request #57 from fivetran/bug/selected-join-table

Bug/selected join table
fivetran · Aug 31, 2023 · d89ede1 · d89ede1
2 parents 9ac3079 + c539fa3
commit d89ede1
Show file tree

Hide file tree

Showing 13 changed files with 23 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+# dbt_google_ads v0.9.3
+[PR #57](https://github.com/fivetran/dbt_google_ads/pull/57) includes the following updates:
+## Bug fixes
+- Updated end models to select key columns from the `stats` source instead of the `reports` source to avoid introducing null values.
+
+## Contributors
+- [@edwardskatie](https://github.com/edwardskatie) ([PR #54](https://github.com/fivetran/dbt_google_ads/pull/54))
+
 # dbt_google_ads v0.9.2 
 
 ## 🎉 Features 🎉

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'google_ads'
-version: '0.9.2'
+version: '0.9.3'
 
 config-version: 2
 require-dbt-version: [">=1.3.0", "<2.0.0"]

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/docs/run_results.json b/docs/run_results.json
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'google_ads_integration_tests'
-version: '0.9.2'
+version: '0.9.3'
 
 profile: 'integration_tests'
 config-version: 2

diff --git a/models/google_ads__account_report.sql b/models/google_ads__account_report.sql
@@ -18,7 +18,7 @@ fields as (
     select
         stats.date_day,
         accounts.account_name,
-        accounts.account_id,
+        stats.account_id,
         accounts.currency_code,
         accounts.auto_tagging_enabled,
         accounts.time_zone,

diff --git a/models/google_ads__ad_group_report.sql b/models/google_ads__ad_group_report.sql
@@ -37,7 +37,7 @@ fields as (
         campaigns.campaign_name,
         campaigns.campaign_id,
         ad_groups.ad_group_name,
-        ad_groups.ad_group_id,
+        stats.ad_group_id,
         ad_groups.ad_group_status,
         ad_groups.ad_group_type,
         sum(stats.spend) as spend,

diff --git a/models/google_ads__ad_report.sql b/models/google_ads__ad_report.sql
@@ -44,7 +44,7 @@ fields as (
         campaigns.campaign_name,
         campaigns.campaign_id,
         ad_groups.ad_group_name,
-        ad_groups.ad_group_id,
+        stats.ad_group_id,
         stats.ad_id,
         ads.ad_name,
         ads.ad_status,

diff --git a/models/google_ads__campaign_report.sql b/models/google_ads__campaign_report.sql
@@ -28,7 +28,7 @@ fields as (
         accounts.account_id,
         accounts.currency_code,
         campaigns.campaign_name,
-        campaigns.campaign_id,
+        stats.campaign_id,
         campaigns.advertising_channel_type,
         campaigns.advertising_channel_subtype,
         campaigns.status,

diff --git a/models/google_ads__keyword_report.sql b/models/google_ads__keyword_report.sql
@@ -45,7 +45,7 @@ fields as (
         stats.campaign_id,
         ad_groups.ad_group_name,
         stats.ad_group_id,
-        criterions.criterion_id,
+        stats.criterion_id,
         criterions.type,
         criterions.status,
         criterions.keyword_match_type,

diff --git a/models/google_ads__url_report.sql b/models/google_ads__url_report.sql
@@ -44,8 +44,8 @@ fields as (
         campaigns.campaign_name,
         campaigns.campaign_id,
         ad_groups.ad_group_name,
-        ad_groups.ad_group_id,
-        ads.ad_id,
+        stats.ad_group_id,
+        stats.ad_id,
         ads.base_url,
         ads.url_host,
         ads.url_path,