-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump plugin sample to v0.1.0, add to npm publish workflow #776
Open
coopernetes
wants to merge
4
commits into
finos:main
Choose a base branch
from
RBC:feat/publish-plugin-sample
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
coopernetes
added
bug
Something isn't working
documentation
Improvements or additions to documentation
plugins
Extensibility of the framework
maintenance
and removed
feature
labels
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
=======================================
Coverage 60.12% 60.12%
=======================================
Files 47 47
Lines 1650 1650
=======================================
Hits 992 992
Misses 658 658 ☔ View full report in Codecov by Sentry. |
coopernetes
commented
Oct 30, 2024
coopernetes
commented
Nov 4, 2024
@maoo @TheJuanAndOnly99 - are we okay to publish this sample NPM project? |
LGTM @JamieSlome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
feature
maintenance
plugins
Extensibility of the framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #771
On hold until after #793 is released so the samples can be updated accordingly along with the docs.