Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #52

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Fix unit tests #52

merged 2 commits into from
Mar 10, 2024

Conversation

maartenpaauw
Copy link
Contributor

After running configure.php and directly pushing all changes, the default tests fail. These changes will make the tests pass.

Version 2.0 will break the prefer lowest test suite
These packages aren't installed by default
@pratikkuikel
Copy link

This is a good change. I recently used this skeleton and got the tests failing after configuration.

@AlexisSerneels
Copy link
Contributor

I guess it would be better to fix the issue by adding dependencies in composer.json instead of removing the default support.

"require-dev": {
        "filament/spatie-laravel-settings-plugin": "^3.2",
        "filament/spatie-laravel-translatable-plugin": "^3.2",
        ...
 },        

@maartenpaauw
Copy link
Contributor Author

I guess it would be better to fix the issue by adding dependencies in composer.json instead of removing the default support.

"require-dev": {
        "filament/spatie-laravel-settings-plugin": "^3.2",
        "filament/spatie-laravel-translatable-plugin": "^3.2",
        ...
 },        

I'm not sure why those two packages are needed by default (and should be installed). Should all new plug-ins be compatible with those two plug-ins? Is that the case?

@chrisreedio
Copy link

I guess it would be better to fix the issue by adding dependencies in composer.json instead of removing the default support.

"require-dev": {
        "filament/spatie-laravel-settings-plugin": "^3.2",
        "filament/spatie-laravel-translatable-plugin": "^3.2",
        ...
 },        

I'm not sure why those two packages are needed by default (and should be installed). Should all new plug-ins be compatible with those two plug-ins? Is that the case?

I have been removing these from the file. I too am curious if we should be leaving these in (and installing them as deps).

@awcodes awcodes merged commit f638491 into filamentphp:main Mar 10, 2024
1 check passed
@maartenpaauw maartenpaauw deleted the fix-unit-tests branch March 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants