This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
fix d2go.config #571
Open
fix d2go.config #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I think the main issue is that we import `reroute_config_path` from `d2go.config.config` in `__init__.py`, but it's actually in `d2go.config.utils`. After fixing this, the namespace forward also works, see `scripts/wangyanghan/autodeps_testbed/d2go_config/TARGETS` Update all TARGETS: ``` fbgs -l "d2go/config:" | xargs printf -- '/data/sandcastle/boxes/%s\n' | xargs arc lint -a ``` For reviewers, only `.autodeps.toml` and files in `d2go/d2go/config/` and `scripts/wangyanghan/autodeps_testbed/d2go_config/` are manually changed, other files are auto modified. Reviewed By: ajinkya-deogade Differential Revision: D46582416 fbshipit-source-id: c801d47717e3297700a7bbd52f974653ee760826
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46582416 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I think the main issue is that we import
reroute_config_pathfromd2go.config.configin__init__.py, but it's actually ind2go.config.utils. After fixing this, the namespace forward also works, seescripts/wangyanghan/autodeps_testbed/d2go_config/TARGETSUpdate all TARGETS:
For reviewers, only
.autodeps.tomland files ind2go/d2go/config/andscripts/wangyanghan/autodeps_testbed/d2go_config/are manually changed, other files are auto modified.Reviewed By: ajinkya-deogade
Differential Revision: D46582416