This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Add bitcode support for iOS #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First off, it's unfortunate this involves maintaining opaque, non-human-readable Xcode projects. If you use CocoaPods, it will be managed in one place and use human-readable configuration. In this case, is the behavior of these build settings documented anywhere? Which targets does this affect, and in what configurations? Does this have an impact on apps that do not use Bitcode? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for building pop using Carthage with bitcode support enabled.
Adds a user-defined setting for
BITCODE_GENERATION_MODE. This is modeled after Alamofire's support for bitcode via Carthage, referenced in Alamofire/Alamofire#835.