Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aws_local_config_parser public #3

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

dmorgan-fa
Copy link
Contributor

@dmorgan-fa dmorgan-fa commented Jul 9, 2024

What

Making this gem public and releasing to rubygems rather than github

I've set the repo to public as well.

@dmorgan-fa dmorgan-fa requested a review from a team as a code owner July 9, 2024 15:41
@dmorgan-fa dmorgan-fa requested a review from DuncSmith July 9, 2024 15:41
@dmorgan-fa dmorgan-fa force-pushed the release-gem-publically branch from 1070356 to 243c3ca Compare July 9, 2024 15:42
# What
Making this gem public and releasing to rubygems rather than github
@dmorgan-fa dmorgan-fa force-pushed the release-gem-publically branch from 243c3ca to eba6394 Compare July 9, 2024 15:43
Copy link
Contributor

@DuncSmith DuncSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Secret needs adding by the looks of it

@dmorgan-fa dmorgan-fa merged commit b50fed7 into main Jul 9, 2024
1 check passed
@dmorgan-fa dmorgan-fa deleted the release-gem-publically branch July 9, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants