fix(board): use array instead of set, update unit tests

src/app/components_ngrx/planner-board-column/planner-board-column.component.html

@@ -1,6 +1,6 @@
 <div class="f8-board-column">
   <div class="f8-board-column__header">
-    <span class="badge">{{ itemCount }} </span>
+    <span class="badge">{{ itemCount ? itemCount : 0 }} </span>
     <span class="f8-board-column__header-title">{{ columnName }}</span>
   </div>
   <div class="f8-board-column__wrapper">

src/app/effects/work-item.effects.ts

@@ -363,12 +363,12 @@ export class WorkItemEffects {
         .switchMap((w: WorkItemUI) => {
           console.log('#### - 5', w);
           return [
-            new WorkItemActions.UpdateSuccess(w),
             new ColumnWorkItemActions.UpdateSuccess({
               workItemId: w.id,
               prevColumnId: wp.payload.prevColumnId,
               newColumnIds: w.columnIds
-            })
+            }),
+            new WorkItemActions.UpdateSuccess(w)
           ];
         })
         .catch((e) => {

src/app/models/board.model.ts

@@ -198,7 +198,7 @@ export class ColumnWorkItemQuery {
 
   getWorkItemsByColumnId(id: string): Observable<WorkItemUI[]> {
     return this.columnWorkitemSource.select(state => state[id])
-      .map(items => items || new Set<string>([]))
-      .flatMap(ids => this.workItemQuery.getWorkItemsByIds(Array.from(ids)));
+      .map(items => items || [])
+      .switchMap(ids => this.workItemQuery.getWorkItemsByIds(ids));
   }
 }

src/app/models/work-item.ts

@@ -649,11 +649,11 @@ export class WorkItemQuery {
     const selector = createSelector(
       workItemEntities,
       state => {
-        return ids.map(i => state[i])
+        return ids.length > 0 ? ids.map(i => state[i])
           // Sometime
           .filter(item => !!item)
           .map(item => this.resolveWorkItem(item))
-          .sort((a, b) => a.order - b.order);
+          .sort((a, b) => b.order - a.order) : [];
       }
     );
     return this.store.select(selector);

src/app/reducers/column-workitem.reducer.spec.ts

@@ -29,9 +29,9 @@ describe('ColumnWorkitemReducer: ', () => {
     ] as WorkItemUI[];
 
     const columWorkItemState: ColumnWorkItemState = {
-      '0000-000-05': new Set(['1', '2']),
-      '0000-000-06': new Set(['1']),
-      '0000-000-07': new Set(['2'])
+      '0000-000-05': ['1', '2'],
+      '0000-000-06': ['1'],
+      '0000-000-07': ['2']
     };
 
     const action = new GetSuccess(workitems);

src/app/reducers/column-workitem.reducer.ts

@@ -9,14 +9,14 @@ export type Action = WorkItemActions.All | ColumnWorkItemActions.All;
 export const ColumnWorkItemReducer: ActionReducer<ColumnWorkItemState> = (state = InitialColumnWorkItemState, action: Action) => {
   switch (action.type) {
     case WorkItemActions.GET_SUCCESS: {
-      const cwState = {...state};
+      let cwState = {};
       action.payload.forEach(item => {
         if (item.columnIds !== null) {
           item.columnIds.forEach(col => {
             if (cwState.hasOwnProperty(col)) {
-              cwState[col].add(item.id);
+              cwState[col] = [...cwState[col], item.id];
             } else {
-              cwState[col] = new Set([item.id]);
+              cwState[col] = [item.id];
             }
           });
         }
@@ -26,16 +26,18 @@ export const ColumnWorkItemReducer: ActionReducer<ColumnWorkItemState> = (state
     case ColumnWorkItemActions.UPDATE_SUCCESS: {
       const cwState = {...state};
       console.log('#### -- 1', cwState);
-      cwState[action.payload.prevColumnId].delete(action.payload.workItemId);
+      cwState[action.payload.prevColumnId] =
+        cwState[action.payload.prevColumnId]
+          .filter(id => id !== action.payload.workItemId) ;
       action.payload.newColumnIds.forEach(col => {
         if (cwState.hasOwnProperty(col)) {
-          cwState[col].add(action.payload.workItemId);
+          cwState[col] = [...cwState[col], action.payload.workItemId];
         } else {
-          cwState[col] = new Set([action.payload.workItemId]);
+          cwState[col] = [action.payload.workItemId];
         }
       });
       console.log('#### -- 2', cwState);
-      return cwState;
+      return {...cwState};
     }
     default:  {
       return {...state};

src/app/states/column-workItem.state.ts

@@ -1,5 +1,5 @@
 export type ColumnWorkItemState = {
-  [id: string]: Set<string>
+  [id: string]: string[]
 };
 
 export const initialState: ColumnWorkItemState = {} as ColumnWorkItemState;