Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store heap dump in a persistence volume #68

Merged
merged 7 commits into from
May 23, 2017
Merged

Store heap dump in a persistence volume #68

merged 7 commits into from
May 23, 2017

Conversation

hectorj2f
Copy link

related to: #61

@hectorj2f hectorj2f self-assigned this Apr 27, 2017
@hectorj2f hectorj2f requested a review from alexeykazakov April 27, 2017 10:00
@hectorj2f
Copy link
Author

ping @vpavlin

vpavlin
vpavlin approved these changes Apr 27, 2017
View reviewed changes
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@hectorj2f
Copy link
Author

Mentioned in a discussion with Den Hall:

hey Hector.. saw your PR.. question for you.. We can do  keep the heap dump but most of the time you just need to look at stack trace.. do you have a specific use case for the heap dump? Also it will be as big as the heap is so if we only have like a 1 GB pv and 4 GB heap.. you'll not get the whole thing..

That means we need to increase the size of the persistence volume from 1GB to 4GB

@bartoszmajsak
Copy link

bartoszmajsak commented May 8, 2017 •
edited
Loading

most of the time you just need to look at stack trace

Sure, but not in our case. We have to learn what is causing mem leak here. Is there an issue with such "big" PV?

Maybe we could think of publishing a dump somewhere before killing the container instead? We only need that internally for the analysis.

bartoszmajsak
bartoszmajsak reviewed May 8, 2017
View reviewed changes
openshift/keycloak.app.yaml Outdated
-Djboss.modules.system.pkgs=org.jboss.byteman
-Djava.awt.headless=true
restartPolicy: Always
securityContext: {}
terminationGracePeriodSeconds: 30
dnsPolicy: ClusterFirst
volumes:
- name: heapdumppath
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why heapdumppath - maybe simply heapdumps? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, heapdumps sounds better for me too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

bartoszmajsak
bartoszmajsak approved these changes May 8, 2017
View reviewed changes
Copy link

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an intermediate solution, this looks good to me. I would like however to explore the possibility to use hooks and transport those dumps to single location instead of growing PVs and thus our env limits.

@hectorj2f
Copy link
Author

[test]

@hectorj2f
Copy link
Author

[test]

@hectorj2f
Copy link
Author

i am going to merge this PR

@hectorj2f hectorj2f merged commit 38ba17b into master May 23, 2017
@hectorj2f hectorj2f deleted the store_heap_dump branch May 23, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpavlin vpavlin vpavlin approved these changes

@bartoszmajsak bartoszmajsak bartoszmajsak approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

Assignees

@hectorj2f hectorj2f

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hectorj2f @bartoszmajsak @alexeykazakov @vpavlin