Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGui-based console #1748

Merged
merged 28 commits into from
Dec 11, 2024
Merged

ImGui-based console #1748

merged 28 commits into from
Dec 11, 2024

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Dec 3, 2024

  • Introduce a new output window based on ImGui. This new output window will duplicate the logs sent to the terminal in case the user isn't using F3D from the terminal.
  • The output window for Windows relying on an external window has been removed.
  • This new log window can be accessed by pressing the key Escape.
  • The previous binding to Escape that will quit the application has been removed.
  • The new command to quit the application exit is added in the application.
  • When a new warning or error is logged and the console is hidden, a small icon on the top right corner will show up to inform the user. The user can then press Escape or click on the icon.
  • At the bottom of the log window, an input field is available to the user where they can type any command registered in F3D.
  • In order to fix a warning always reported to the user when not using GLX in automatic rendering backend mode, the VTK logic has been mimicked but the GLX context selection is now silently failing.

Badge informing the user a new warning is logged:
Screenshot 2024-12-06 at 18 10 31

The console opened, showing all the logs:
Screenshot 2024-12-06 at 18 10 50

@Meakk Meakk self-assigned this Dec 3, 2024
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs work

Copy link

github-actions bot commented Dec 4, 2024

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@Meakk Meakk force-pushed the console-imgui branch 2 times, most recently from c43224d to 8eff437 Compare December 5, 2024 19:58
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 97.12919% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (7f8aeb6) to head (339992a).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
library/src/window_impl.cxx 60.00% 4 Missing ⚠️
vtkext/private/module/vtkF3DEGLRenderWindow.cxx 83.33% 1 Missing ⚠️
vtkext/private/module/vtkF3DImguiObserver.cxx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
+ Coverage   75.95%   76.30%   +0.35%     
==========================================
  Files         120      124       +4     
  Lines       12009    12194     +185     
==========================================
+ Hits         9121     9305     +184     
- Misses       2888     2889       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small optional change if you want

@Meakk Meakk merged commit 4ab7104 into f3d-app:master Dec 11, 2024
44 checks passed
@Meakk Meakk deleted the console-imgui branch December 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants