Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android images #32

Merged
merged 19 commits into from
Jan 30, 2025
Merged

Add Android images #32

merged 19 commits into from
Jan 30, 2025

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 28, 2025 •
edited
Loading

Add new Android images, the following dependencies are NOT built:

  • OpenUSD: It defines ARCH_OS_LINUX variable and goes through invalid code path. It seems like Android support is lacking
  • TBB: Only used by OpenUSD, it's not necessary
  • OpenVDB: Experimental support in F3D, and VTK Android build is not building IOVDB module
  • OSPRay: Raytracing makes little sense on an Android app

@Meakk Meakk self-assigned this Jan 28, 2025
@Meakk Meakk requested a review from mwestphal January 30, 2025 09:31
mwestphal
mwestphal requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions

@Meakk Meakk requested a review from mwestphal January 30, 2025 12:38
mwestphal
mwestphal approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming 1ab19927725cb4b86af8afaf255ed0ffc9fc913a works

@Meakk Meakk merged commit c0f08a1 into f3d-app:main Jan 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meakk @mwestphal