HotelRoomDetailUseCase 추가 및 리팩토링 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-Toru
reviewed
Nov 16, 2024
| val roomInternet: String, | ||
| val roomRefrigerator: String, | ||
| val roomHairdryer: String, | ||
| val roomImages: List<String> = emptyList(), |
There was a problem hiding this comment.
방 정보에서 이미지가 없는 경우를 대비해서 roomImages 만 빈 리스트로 디폴트값을 만들어 준 걸까요? :)
There was a problem hiding this comment.
Mapper에서 List를 Filter하는 과정에서 Match되는 값이 없으면 Null 반환인 줄 알고 빈 리스트를 디폴트로 넣어놨는데,
filterNot 함수를 살펴보니 Match되는 값이 없으면 빈 List를 반환하는 것 같네요. emptyList()는 지워도 될 것 같습니다.
| ) | ||
|
|
||
| fun DetailInfoDTO.toHotelRoomDetail(): HotelRoomDetail { | ||
| val images = listOf(roomImg1, roomImg2, roomImg3, roomImg4, roomImg5).filterNot { |
There was a problem hiding this comment.
나쁘지 않습니다만 왠지 이걸 메서드로 하나 뺄 수도 있을 거 같긴 합니다.
parameter 로는 varargs 를 넣어 주면 여러개를 받을 수 있지 않을까요?
There was a problem hiding this comment.
조언해주신대로 함수로 빼봤습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항