[#17] 상세화면 (DetailScreen) 구현 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-Toru
reviewed
Oct 25, 2024
| @Query("contentId") contentId: String, | ||
| @Query("contentTypeId") contentTypeId: String | ||
| ): ApiResponse<DetailIntroDTO> | ||
| /* |
|
|
||
| data class DetailCommonDTO( | ||
| val homepage: String, | ||
| val overview: String |
| @Query("contentTypeId") contentTypeId: Int | ||
| ) | ||
| */ | ||
| @GET("detailImage1") |
There was a problem hiding this comment.
방금 든 생각인데, URL 을 const 로 정의해서 써도 될 거 같습니다
| @SerializedName("subfacility") | ||
| val subFacility: String?, | ||
| @SerializedName("reservationurl") | ||
| val reservationUrl: String? |
There was a problem hiding this comment.
trailing comma를 넣어도 될 거 같습니다.
그리고 만일의 경우를 대비해 초기값을 넣어도 될 거 같아요
| val restDate: String? = null, | ||
| val fee: String? = null, | ||
| val menus: String? = null, | ||
| val place: String? = null |
| .data(detailState.firstImage) | ||
| .size(Size.ORIGINAL) | ||
| .build(), | ||
| colorFilter = if(detailState.firstImage.isNotEmpty()) |
There was a problem hiding this comment.
if-else 를 사용할 때 {} 를 적절히 써 주면 가독성에 도움이 될 거 같기도 합니다
| val contentTypeId: String = "", | ||
| val detailCommon: DetailCommonDTO = DetailCommonDTO("",""), | ||
| val detailIntro: CommonDetail = CommonDetail(), | ||
| val images: List<DetailImageDTO> = emptyList() |
| ) | ||
| getDetailImage( | ||
| detailParcel.contentId, | ||
| if(detailParcel.contentTypeId == TYPE_RESTAURANT) |
There was a problem hiding this comment.
if - else 에 {} 를 적절히 써 주는 게 좋을 거 같아요
|
|
||
| @Provides | ||
| @Singleton | ||
| fun provideDetailRepository(detailApi: DetailApi): DetailRepository { |
There was a problem hiding this comment.
방금 든 생각인데, 이 부분도 @Binds 를 이용해서 interface 를 리턴할 수 있도록 할 수 있지 않을까 하는 생각이 드네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
동작화면
Screen_recording_20241024_135309.mp4