[#15] 검색화면 (SearchScreen) 구현 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksw4015
added
enhancement
f-lab-Toru
reviewed
Oct 22, 2024
| @Query("pageNo") pageNo: Int, | ||
| @Query("keyword") keyword: String, | ||
| @Query("contentTypeId") contentTypeId: String? = null | ||
| ): ApiResponse<LocationBasedDTO> |
There was a problem hiding this comment.
방금 든 생각인데, @QueryMap 을 사용하면 여러 개의 쿼리를 맵 하나에 넣어서 좀더 간편하게 할 수 있을 거 같아요.
https://futurestud.io/tutorials/retrofit-2-add-multiple-query-parameter-with-querymap
There was a problem hiding this comment.
@QueryMap을 쓰기에는 좀 애매하다고 생각했었는데, 한 번 적용해 보도록 하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
멘토님께
동작화면
Screen_recording_20241021_200645.mp4