-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11] HotelScreen 구현 #12
Conversation
# Conflicts: # app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetCultureCenterForHomeUseCase.kt # app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetCultureCenterForHomeUseCaseImpl.kt # app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetLeisureSportsForHomeUseCase.kt # app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetLeisureSportsForHomeUseCaseImpl.kt # app/src/main/java/kr/ksw/visitkorea/domain/usecase/model/CommonCardModel.kt # app/src/main/java/kr/ksw/visitkorea/domain/usecase/model/CultureCenter.kt # app/src/main/java/kr/ksw/visitkorea/presentation/home/viewmodel/HomeState.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
별다른 코멘트를 남길 필요가 없네요. 깔끔하게 잘 하신 거 같고, 스트링값들은 resource 파일로 옮긴다고 하셨으니 다음에 정리하시면 될 거 같고요.
위경도값을 string 으로 넘기는 부분도 const 로 처리하면 될 거 같습니다.
@@ -22,7 +22,8 @@ data class LocationBasedDTO( | |||
val mapX: String, | |||
@SerializedName("mapy") | |||
val mapY: String, | |||
val cat3: String, | |||
@SerializedName("cat3") | |||
val category: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좀더 의미있는 parameter 명이 된 거 같아 좋습니다
감사합니다! |
변경사항
멘토님께
동작화면
Screen_recording_20241014_201924.mp4