Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11] HotelScreen 구현 #12

Merged
merged 6 commits into from
Oct 17, 2024
Merged

[#11] HotelScreen 구현 #12

merged 6 commits into from
Oct 17, 2024

Conversation

ksw4015
Copy link
Collaborator

@ksw4015 ksw4015 commented Oct 14, 2024

변경사항

  • HotelScreen이 추가되었습니다.
  • Paging 라이브러리 의존성이 추가되었습니다.
  • 위치기반 검색 Api에 대한 PagingSource가 추가되었습니다.
  • CultureCenter와 LeisureSports class를 삭제하고 CommonCardModel class로 통합하였습니다.

멘토님께

  • View에서 사용하는 하드코딩된 String들은 1차 구현완료 후 일괄적으로 String Resources로 옮길 예정입니다.

동작화면

Screen_recording_20241014_201924.mp4

# Conflicts:
#	app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetCultureCenterForHomeUseCase.kt
#	app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetCultureCenterForHomeUseCaseImpl.kt
#	app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetLeisureSportsForHomeUseCase.kt
#	app/src/main/java/kr/ksw/visitkorea/domain/usecase/home/GetLeisureSportsForHomeUseCaseImpl.kt
#	app/src/main/java/kr/ksw/visitkorea/domain/usecase/model/CommonCardModel.kt
#	app/src/main/java/kr/ksw/visitkorea/domain/usecase/model/CultureCenter.kt
#	app/src/main/java/kr/ksw/visitkorea/presentation/home/viewmodel/HomeState.kt
@ksw4015 ksw4015 added the main hotel hotel screen develop label Oct 14, 2024
@ksw4015 ksw4015 requested a review from f-lab-Toru October 14, 2024 11:21
@ksw4015 ksw4015 self-assigned this Oct 14, 2024
Copy link

@f-lab-Toru f-lab-Toru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

별다른 코멘트를 남길 필요가 없네요. 깔끔하게 잘 하신 거 같고, 스트링값들은 resource 파일로 옮긴다고 하셨으니 다음에 정리하시면 될 거 같고요.
위경도값을 string 으로 넘기는 부분도 const 로 처리하면 될 거 같습니다.

@@ -22,7 +22,8 @@ data class LocationBasedDTO(
val mapX: String,
@SerializedName("mapy")
val mapY: String,
val cat3: String,
@SerializedName("cat3")
val category: String,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좀더 의미있는 parameter 명이 된 거 같아 좋습니다

@ksw4015
Copy link
Collaborator Author

ksw4015 commented Oct 17, 2024

감사합니다!

@ksw4015 ksw4015 merged commit 60afd7e into main Oct 17, 2024
1 check failed
@ksw4015 ksw4015 deleted the feature/11 branch October 21, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main hotel hotel screen develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants