Skip to content

Commit

Permalink
style: add trailing comma to data class, rename App class
Browse files Browse the repository at this point in the history
  • Loading branch information
ksw4015 committed Sep 30, 2024
1 parent 5f6c352 commit ab83389
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ android {
targetCompatibility = JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = "17"
jvmTarget = JavaVersion.VERSION_17.toString()
}
buildFeatures {
buildConfig = true
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

<application
android:name=".App"
android:name=".app.VisitKoreaApp"
android:allowBackup="true"
android:dataExtractionRules="@xml/data_extraction_rules"
android:fullBackupContent="@xml/backup_rules"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package kr.ksw.visitkorea
package kr.ksw.visitkorea.app

import android.app.Application
import dagger.hilt.android.HiltAndroidApp

@HiltAndroidApp
class App : Application()
class VisitKoreaApp : Application()
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package kr.ksw.visitkorea.data.remote.dto

data class AreaCodeDTO(
val code: String,
val name: String
val name: String,
)
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package kr.ksw.visitkorea.data.remote.model

data class ApiResponse<T>(
val response: CommonResponse<T>
val response: CommonResponse<T>,
)
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ data class CommonBody<T>(
val numOfRows: Int,
val pageNo: Int,
val totalCount: Int,
val items: CommonItem<T>
val items: CommonItem<T>,
)
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package kr.ksw.visitkorea.data.remote.model

data class CommonHeader(
val resultCode: String,
val resultMsg: String
val resultMsg: String,
)
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package kr.ksw.visitkorea.data.remote.model

data class CommonItem<T>(
val item: List<T>
val item: List<T>,
)
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package kr.ksw.visitkorea.data.remote.model

data class CommonResponse<T>(
val header: CommonHeader,
val body: CommonBody<T>
val body: CommonBody<T>,
)
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class AreaCodeApiTest {

@Test
fun `getSigunguCode request success, valid area code`() = runTest {
// val areaCodeItems = fakeAreaCodeRepository.getSigunguCode("1").getOrNull()
val areaCodeItems = fakeAreaCodeRepository.getSigunguCode("31").getOrNull()
assert(areaCodeItems != null)
}
Expand Down

0 comments on commit ab83389

Please sign in to comment.